[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Whitespace cleanup in the generator



On 05/01/2011 01:57 PM, Matthias Bolte wrote:
> Break long lines and change spacing of keyword arguments to match
> Python style standards better.
> 
> No functional change included.
> ---
>  src/esx/esx_vi_generator.py |  369 ++++++++++++++++++++++++++++--------------
>  1 files changed, 246 insertions(+), 123 deletions(-)

I don't know the python style standards, but I could at least review
this on the grounds of looking like safe whitespace changes.

ACK.

> @@ -830,7 +908,8 @@ class Object(Type):
>  
>                  if self.features & Object.FEATURE__LIST:
>                      source += "/* esxVI_%s_SerializeList */\n" % self.name
> -                    source += "ESX_VI__TEMPLATE__LIST__SERIALIZE(%s)\n\n" % self.name
> +                    source += "ESX_VI__TEMPLATE__LIST__SERIALIZE(%s)\n\n" \
> +                              % self.name
>  
>          # deserilaize

You may want to do a followup patch to fix typos like this.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]