[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Change generated method parameter autobinding



2011/5/16 Eric Blake <eblake redhat com>:
> On 05/14/2011 04:31 AM, Matthias Bolte wrote:
>> 2011/5/13 Eric Blake <eblake redhat com>:
>>> On 05/01/2011 01:57 PM, Matthias Bolte wrote:
>>>> Instead of specifing the type of the managed object directly specify
>>>> the ServiceContent member name. This way the mapping dictionary can be
>>>> removed.
>
>>>
>>> This fell apart for me; I don't know how to fix it, so from this point
>>> on, you'll have to rebase and post v2.
>>>
>>>  CC     libvirt_driver_esx_la-esx_vi_methods.lo
>>> In file included from esx/esx_vi_methods.c:288:0:
>>> esx/esx_vi_methods.generated.c: In function 'esxVI_RetrieveProperties':
>>> esx/esx_vi_methods.generated.c:520:278: error: 'esxVI_ServiceContent'
>>> has no member named 'PropertyCollector'
>>
>> One line of change that should have been in this patch slipped into
>> the next one :(
>>
>> Here's a v2 that fixes this.
>
> ACK to v2.
>

Thanks, pushed v2.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]