[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/7] sched: introduce virDomainGetSchedulerParametersFlags



On 05/17/2011 09:18 PM, Hu Tao wrote:
>> +int
>> +virDomainGetSchedulerParametersFlags(virDomainPtr domain,
>> +                                     virSchedParameterPtr params, int *nparams,
>> +                                     unsigned int flags)
>> +{
>> +    virConnectPtr conn;
>> +
>> +    VIR_DOMAIN_DEBUG(domain, "params=%p, nparams=%p, flags=%u",
>> +                     params, nparams, flags);
>> +
>> +    virResetLastError();
>> +
>> +    if (!(flags & (VIR_DOMAIN_SCHEDPARAM_LIVE |
>> +                   VIR_DOMAIN_SCHEDPARAM_CONFIG |
>> +                   VIR_DOMAIN_SCHEDPARAM_CURRENT))) {
>> +        virLibDomainError(VIR_ERR_INVALID_ARG, __FUNCTION__);
>> +        virDispatchError(NULL);
>> +        return -1;
>> +    }
> 
> Causes problem with:
> 
> virsh schedinfo vm --set cpu_shares=1024 --current
> 
> where vm is an inactive domain.

Yep, the solution is the same as for your SetSchedulerParametersFlags -
I agree with removing the flag check in libvirt.c and instead making the
callbacks do the check.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]