[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC Patch 2/3]virsh: Change log level order



On 05/20/2011 05:13 AM, Eric Blake wrote:
On 05/09/2011 01:08 AM, Supriya Kannery wrote:
@@ -2103,7 +2103,7 @@ cmdDominfo(vshControl *ctl, const vshCmd

      /* Check and display whether the domain is persistent or not */
      persistent = virDomainIsPersistent(dom);
-    vshDebug(ctl, 5, "Domain persistent flag value: %d\n", persistent);
+    vshDebug(ctl, 4, "Domain persistent flag value: %d\n", persistent);

Please resubmit by using VSH_ERR_DEBUG rather than the magic number '5'
(or '4') in all of these vshDebug statements.  If we're going to clean
up this code, let's clean it up right.


Thanks! for reviewing this patchset. Posted version 2 of this patch,
which replaces magic numbers with corresponding VSH_ERR_xx.
http://www.mail-archive.com/libvir-list redhat com/msg38280.html

Rgds,
Supriya


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]