[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/5] remote generator: Don't rely on $_ being stable over a large function



2011/5/16 Eric Blake <eblake redhat com>:
> On 05/15/2011 12:23 AM, Matthias Bolte wrote:
>> Replace $calls{$_} with $call in the dispatch bodies generator function.
>>
>> No functional change included.
>> ---
>>  daemon/remote_generator.pl |  100 ++++++++++++++++++++++---------------------
>>  1 files changed, 51 insertions(+), 49 deletions(-)
>>
>> diff --git a/daemon/remote_generator.pl b/daemon/remote_generator.pl
>> index c2468b9..5725583 100755
>> --- a/daemon/remote_generator.pl
>> +++ b/daemon/remote_generator.pl
>> @@ -272,11 +272,13 @@ elsif ($opt_b) {
>>      my @keys = sort (keys %calls);
>>
>>      foreach (@keys) {
>> +        my $call = $calls{$_};
>> +
>>          # skip things which are REMOTE_MESSAGE
>> -        next if $calls{$_}->{msg};
>> +        next if $call->{msg};
>
> ACK.
>

Thanks, pushed.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]