[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] build: generate files when building without libvirtd



At 2011-5-13 17:36, Daniel P. Berrange write:
On Fri, May 13, 2011 at 04:02:13PM +0800, Wen Congyang wrote:
Steps to reproduce this problem:
1. # ./autogen.sh --without-libvirtd
2. # make dist
    ...
    make[1]: Entering directory `/home/wency/source/libvirt-nodaemon/daemon'
    make[1]: *** No rule to make target `remote_dispatch_prototypes.h', needed by `distdir'.  Stop.
    make[1]: Leaving directory `/home/wency/source/libvirt-nodaemon/daemon'
    make: *** [distdir] Error 1

---
  daemon/Makefile.am |  106 ++++++++++++++++++++++++++--------------------------
  1 files changed, 53 insertions(+), 53 deletions(-)

diff --git a/daemon/Makefile.am b/daemon/Makefile.am
index 2095c1c..338663f 100644
--- a/daemon/Makefile.am
+++ b/daemon/Makefile.am
@@ -53,6 +53,59 @@ EXTRA_DIST =						\

  BUILT_SOURCES =

+REMOTE_PROTOCOL = $(top_srcdir)/src/remote/remote_protocol.x
+QEMU_PROTOCOL = $(top_srcdir)/src/remote/qemu_protocol.x
+
+$(srcdir)/remote_dispatch_prototypes.h: $(srcdir)/remote_generator.pl \
+		$(REMOTE_PROTOCOL)
+	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -c -p remote \
+	  $(REMOTE_PROTOCOL)>  $@
+
+$(srcdir)/remote_dispatch_table.h: $(srcdir)/remote_generator.pl \
+		$(REMOTE_PROTOCOL)
+	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -c -t remote \
+	  $(REMOTE_PROTOCOL)>  $@
+
+$(srcdir)/remote_dispatch_args.h: $(srcdir)/remote_generator.pl \
+		$(REMOTE_PROTOCOL)
+	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -c -a remote \
+	  $(REMOTE_PROTOCOL)>  $@
+
+$(srcdir)/remote_dispatch_ret.h: $(srcdir)/remote_generator.pl \
+		$(REMOTE_PROTOCOL)
+	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -c -r remote \
+	  $(REMOTE_PROTOCOL)>  $@
+
+$(srcdir)/remote_dispatch_bodies.h: $(srcdir)/remote_generator.pl \
+		$(REMOTE_PROTOCOL)
+	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -c -b remote \
+	  $(REMOTE_PROTOCOL)>  $@
+
+$(srcdir)/qemu_dispatch_prototypes.h: $(srcdir)/remote_generator.pl \
+		$(QEMU_PROTOCOL)
+	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -p qemu \
+	  $(QEMU_PROTOCOL)>  $@
+
+$(srcdir)/qemu_dispatch_table.h: $(srcdir)/remote_generator.pl \
+		$(QEMU_PROTOCOL)
+	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -t qemu \
+	  $(QEMU_PROTOCOL)>  $@
+
+$(srcdir)/qemu_dispatch_args.h: $(srcdir)/remote_generator.pl \
+		$(QEMU_PROTOCOL)
+	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -a qemu \
+	  $(QEMU_PROTOCOL)>  $@
+
+$(srcdir)/qemu_dispatch_ret.h: $(srcdir)/remote_generator.pl \
+		$(QEMU_PROTOCOL)
+	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -r qemu \
+	  $(QEMU_PROTOCOL)>  $@
+
+$(srcdir)/qemu_dispatch_bodies.h: $(srcdir)/remote_generator.pl \
+		$(QEMU_PROTOCOL)
+	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -b qemu \
+	  $(QEMU_PROTOCOL)>  $@
+
  if WITH_LIBVIRTD

  man8_MANS = libvirtd.8
@@ -210,59 +263,6 @@ endif
  remote.c: $(DAEMON_GENERATED)
  remote.h: $(DAEMON_GENERATED)

-REMOTE_PROTOCOL = $(top_srcdir)/src/remote/remote_protocol.x
-QEMU_PROTOCOL = $(top_srcdir)/src/remote/qemu_protocol.x
-
-$(srcdir)/remote_dispatch_prototypes.h: $(srcdir)/remote_generator.pl \
-		$(REMOTE_PROTOCOL)
-	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -c -p remote \
-	  $(REMOTE_PROTOCOL)>  $@
-
-$(srcdir)/remote_dispatch_table.h: $(srcdir)/remote_generator.pl \
-		$(REMOTE_PROTOCOL)
-	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -c -t remote \
-	  $(REMOTE_PROTOCOL)>  $@
-
-$(srcdir)/remote_dispatch_args.h: $(srcdir)/remote_generator.pl \
-		$(REMOTE_PROTOCOL)
-	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -c -a remote \
-	  $(REMOTE_PROTOCOL)>  $@
-
-$(srcdir)/remote_dispatch_ret.h: $(srcdir)/remote_generator.pl \
-		$(REMOTE_PROTOCOL)
-	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -c -r remote \
-	  $(REMOTE_PROTOCOL)>  $@
-
-$(srcdir)/remote_dispatch_bodies.h: $(srcdir)/remote_generator.pl \
-		$(REMOTE_PROTOCOL)
-	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -c -b remote \
-	  $(REMOTE_PROTOCOL)>  $@
-
-$(srcdir)/qemu_dispatch_prototypes.h: $(srcdir)/remote_generator.pl \
-		$(QEMU_PROTOCOL)
-	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -p qemu \
-	  $(QEMU_PROTOCOL)>  $@
-
-$(srcdir)/qemu_dispatch_table.h: $(srcdir)/remote_generator.pl \
-		$(QEMU_PROTOCOL)
-	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -t qemu \
-	  $(QEMU_PROTOCOL)>  $@
-
-$(srcdir)/qemu_dispatch_args.h: $(srcdir)/remote_generator.pl \
-		$(QEMU_PROTOCOL)
-	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -a qemu \
-	  $(QEMU_PROTOCOL)>  $@
-
-$(srcdir)/qemu_dispatch_ret.h: $(srcdir)/remote_generator.pl \
-		$(QEMU_PROTOCOL)
-	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -r qemu \
-	  $(QEMU_PROTOCOL)>  $@
-
-$(srcdir)/qemu_dispatch_bodies.h: $(srcdir)/remote_generator.pl \
-		$(QEMU_PROTOCOL)
-	$(AM_V_GEN)perl -w $(srcdir)/remote_generator.pl -b qemu \
-	  $(QEMU_PROTOCOL)>  $@
-
  LOGROTATE_CONFS = libvirtd.qemu.logrotate libvirtd.lxc.logrotate \
  		  libvirtd.uml.logrotate libvirtd.logrotate

ACK

This patch does not duplicate Eric's patch.
So I pushed it.



Daniel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]