[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] python: Fix typo in bindings



On Mon, May 23, 2011 at 10:57:16AM +0200, Michal Privoznik wrote:
> This typo caused a bug in which we wanted to free() invalid pointer.
> ---
>  python/libvirt-override.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/python/libvirt-override.c b/python/libvirt-override.c
> index 11e1d0c..a151e78 100644
> --- a/python/libvirt-override.c
> +++ b/python/libvirt-override.c
> @@ -2945,7 +2945,7 @@ libvirt_virEventRegisterImpl(ATTRIBUTE_UNUSED PyObject * self,
>          return VIR_PY_INT_FAIL;
>  
>      /* Get argument string representations (for error reporting) */
> -    addHandleName = py_str(addTimeoutObj);
> +    addHandleName = py_str(addHandleObj);
>      updateHandleName = py_str(updateHandleObj);
>      removeHandleName = py_str(removeHandleObj);
>      addTimeoutName = py_str(addTimeoutObj);

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]