[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] schema: Add graphics element passwdValidTo attribute to schema



On 26.05.2011 15:54, Daniel Veillard wrote:
> On Thu, May 26, 2011 at 01:50:37PM +0200, Michal Privoznik wrote:
>> We support this in code, but forgot to add this to RNG schema as well.
>> According to documentation, the value match the dateTime type.
>> ---
>>  docs/schemas/domain.rng |   10 ++++++++++
>>  1 files changed, 10 insertions(+), 0 deletions(-)
>>
>> diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng
>> index 1ae5b36..c270815 100644
>> --- a/docs/schemas/domain.rng
>> +++ b/docs/schemas/domain.rng
>> @@ -1222,6 +1222,11 @@
>>                <text/>
>>              </attribute>
>>            </optional>
>> +          <optional>
>> +            <attribute name="passwdValidTo">
>> +              <data type="dateTime"/>
>> +            </attribute>
>> +          </optional>
>>          </group>
>>          <group>
>>            <attribute name="type">
>> @@ -1260,6 +1265,11 @@
>>                <text/>
>>              </attribute>
>>            </optional>
>> +          <optional>
>> +            <attribute name="passwdValidTo">
>> +              <data type="dateTime"/>
>> +            </attribute>
>> +          </optional>
>>            <interleave>
>>              <zeroOrMore>
>>                <element name="channel">
> 
>  Hum, I had to actually reread the XSD spec for this
>    http://www.w3.org/TR/2001/REC-xmlschema-2-20010502/#dateTime
> as well as the piece of code in virDomainGraphicsAuthDefParseXML()
> to convince myself we could reuse the XSD type directly, and true that
> should eb okay since we ignore any timezone suffix in parsing.
> 
>  ACK :-)
> 
> Daniel
> 
thanks, pushed.
Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]