[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] nwfilter: reorder locks



On 05/11/2011 02:36 PM, Stefan Berger wrote:
> This patch reorders the locks for the nwfilter updates and the access
> the nwfilter objects. In the case that the IP address learning thread
> was instantiating filters while an update happened, the previous order
> lead to a deadlock.
> 
> I am also adding a text file describing the locking order of the
> nwfilter subsystem.
> 
> Signed-off-by: Stefan Berger <stefanb us ibm com>
> 
> ---
>  src/conf/nwfilter_conf.c       |    9 ++++----
>  src/nwfilter/locking.txt       |   45

Hmm.  We have daemon/THREADING.txt, src/qemu/THREADS.txt, and now
src/nwfilter/locking.txt.

Let's pick a single name for all 3 (THREADS.txt is my favorite - it's
shortest, and by being ALL-CAPS, it sorts first in the directory for
when you need it, and does not interfere with .c files for when you
don't want to be bothered by it).

I think you can be pre-approved to push an independent patch that
trivially renames THREADING.txt to THREADS.txt, plus the Makefile.am
fallout.

Also, you need to list your new file in src/Makefile.am.

ACK with those changes.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]