[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] storage: List directory volumes for dir/fs/netfs pools



On 05/26/2011 02:21 PM, Cole Robinson wrote:
> Since directories can be used for <filesystem> passthrough, they are
> basically storage volumes.
> 
> v2:
>     Skip ., .., lost+found dirs
> 
> v3:
>     Use gnulib last_component
> 

> diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c
> index 02e455f..f23cf60 100644
> --- a/src/storage/storage_backend.c
> +++ b/src/storage/storage_backend.c
> @@ -36,6 +36,7 @@
>  #include <sys/stat.h>
>  #include <sys/param.h>
>  #include <dirent.h>
> +#include <dirname.h>

dirname.h is a gnulib header ("dirname.h"), not a system header
(<dirname.h>).  Sink it down to live with other gnulib/libvirt internal
headers.

ACK with that nit fixed, no need to post a v4 to the list.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]