[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()



2011/5/27 Daniel Veillard <veillard redhat com>:
> On Fri, May 27, 2011 at 03:12:26PM +0200, Jean-Baptiste Rouault wrote:
>> On Friday 27 May 2011 13:51:05 Matthias Bolte wrote:
>>
>> > We need distinguish between getline returning -1 because of EOF and
>> > because of another error. I missed this problem in the other
>> > regression fix and posted a follow up patch [1] for this.
>> >
>> > I propose the attached patch as v2 for you patch. I assume you have an
>> > OpenVZ setup at hand, could you test this patch?
>> >
>> > [1] https://www.redhat.com/archives/libvir-list/2011-May/msg01788.html
>> >
>> > Matthias
>>
>> I tested your patch and it seems to work fine.
>
>  ACK then :-)
>
> Daniel
>

Thanks, pushed then.

There are other usages of getline in the OpenVZ driver, but they
should all be safe because they don't distinguish between 0 and -1,
except openvzGetProcessInfo.

Jean-Baptiste could you test virsh dominfo of a running OpenVZ domain?
I expect it to currently fail and will post a patch for it.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]