[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Start of freeze for libvirt-0.9.7 and availability of rc1



On Mon, Oct 31, 2011 at 05:51:55PM +0800, Daniel Veillard wrote:
>   We are now entering the freeze for libvirt-0.9.7 .
> We may make an exception for patch set which got a few round of reviews
> though, like Stefan's ones (v4 IIRC), and anything which we know may
> need fixing in the API before the release.
> 
> I have made a release candidate 1 tarball (and associated rpms) at
>    ftp://libvirt.org/libvirt/libvirt-0.9.7-rc1.tar.gz
> 
> I think I will make an rc2 on Wed or Thu and then try to
> make the release around Friday of the end of the week if things
> looks good.
> 
>   Please give it a try !
Built fine on most Debian architectures:

	https://buildd.debian.org/status/package.php?p=libvirt&suite=experimental

The built failure on amd64 is due to virnetsockettest failing with:

 5) Socket UNIX Accept... libvir: RPC error : Path /build/buildd-libvirt_0.9.7~rc1-1-amd64-EGXZTE/libvirt-0.9.7~rc1/debian/build/tests/virnetsockettest-test.sock too long for unix socket: Cannot allocate memory

since the socket path doesn't fit in UNIX_PATH_MAX. Since exceeding the
path shouldn't't be fatal I'm using the attached patch.
Cheers,
 -- Guido
From: =?UTF-8?q?Guido=20G=C3=BCnther?= <agx sigxcpu org>
Date: Wed, 2 Nov 2011 19:02:42 +0100
Subject: Skip socket test if we exceed UNIX_PATH_MAX.

As seen on the amd64 buildd with:

 5) Socket UNIX Accept... libvir: RPC error : Path /build/buildd-libvirt_0.9.7~rc1-1-amd64-EGXZTE/libvirt-0.9.7~rc1/debian/build/tests/virnetsockettest-test.sock too long for unix socket: Cannot allocate memory
---
 tests/virnetsockettest.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/tests/virnetsockettest.c b/tests/virnetsockettest.c
index 1b88605..d7c0c4f 100644
--- a/tests/virnetsockettest.c
+++ b/tests/virnetsockettest.c
@@ -205,11 +205,13 @@ static int testSocketUNIXAccept(const void *data ATTRIBUTE_UNUSED)
     if (progname[0] == '/') {
         if (virAsprintf(&path, "%s-test.sock", progname) < 0) {
             virReportOOMError();
+            ret = EXIT_AM_SKIP;
             goto cleanup;
         }
     } else {
         if (virAsprintf(&path, "%s/%s-test.sock", abs_builddir, progname) < 0) {
             virReportOOMError();
+            ret = EXIT_AM_SKIP;
             goto cleanup;
         }
     }
@@ -254,11 +256,13 @@ static int testSocketUNIXAddrs(const void *data ATTRIBUTE_UNUSED)
     if (progname[0] == '/') {
         if (virAsprintf(&path, "%s-test.sock", progname) < 0) {
             virReportOOMError();
+            ret = EXIT_AM_SKIP;
             goto cleanup;
         }
     } else {
         if (virAsprintf(&path, "%s/%s-test.sock", abs_builddir, progname) < 0) {
             virReportOOMError();
+            ret = EXIT_AM_SKIP;
             goto cleanup;
         }
     }
-- 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]