[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] remote: fix mingw32 build



On 11/04/2011 02:12 PM, Laine Stump wrote:
tty is initialized, and later set in code that is compiled for all
platforms, but is only used in a section that's inside #ifndef WIN32.
---
  src/remote/remote_driver.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index ea7fb24..f3b8ad5 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -377,7 +377,7 @@ doRemoteOpen (virConnectPtr conn,
       */
      char *name = NULL, *command = NULL, *sockname = NULL, *netcat = NULL;
      char *port = NULL, *authtype = NULL, *username = NULL;
-    bool sanity = true, verify = true, tty = true;
+    bool sanity = true, verify = true, tty ATTRIBUTE_UNUSED = true;
      char *pkipath = NULL, *keyfile = NULL;

ACK - that function's rather big, but I agree that in the WIN32 case tty is only ever assigned, and that this attribute shuts up the compiler.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]