[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] bug: try to take disk snapshot for LVM2 Volume



On 11/06/2011 09:14 PM, MATSUDA, Daiki wrote:
> I made the patch for the problem to take the snapshot but qcow2. It use
> the 'qemu-img' command, I know that it is not essential solution. But I
> think it is better than to link qemu's libraries.
> 
> Regards

> @@ -9002,6 +9021,13 @@ qemuDomainSnapshotCreateSingleDiskActive
>           return -1;
>       }
> 
> +    ret = qemuDomainSnapshotCheckSrcQcow2(src->disk);
> +    if (ret) {
> +        qemuReportError(VIR_ERR_INTERNAL_ERROR,
> +                        "%s", _("src image is not qcow2 format"));
> +        return ret;
> +    }

NACK.  There is nothing inherently wrong with the source file not being
a qcow2 file.  The whole point of creating a runtime snapshot is that
the original file (of _any_ format) becomes the backing file of a new
qcow2 file, so that the original file now serves as the snapshot.
Forbidding a live snapshot of a raw source file interferes with this intent.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]