[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 01/13] Define keepalive protocol



On Thu, Oct 27, 2011 at 06:05:37PM +0200, Jiri Denemark wrote:
> The keepalive program has two procedures: PING, and PONG.
> Both are used only in asynchronous messages and the sender doesn't wait
> for any reply. However, the party which receives PING messages is
> supposed to react by sending PONG message the other party, but no
> explicit binding between PING and PONG messages is made. For backward
> compatibility neither server nor client are allowed to send keepalive
> messages before checking that remote party supports them.
> ---
> Notes:
>     Version 3 was ACKed provided I do the following changes:
> 
>     Version 4:
>     - update systemptap functions with the new protocol
>     - s/KEEPALIVE_VERSION/KEEPALIVE_PROTOCOL_VERSION/ to make stp generator
>       happy
>     
>     Version 3:
>     - remove ADVERTISE message which is no longer used
>     
>     Version 2:
>     - no change
> 
>  .gitignore                     |    1 +
>  src/Makefile.am                |   19 ++++++++++++++-----
>  src/rpc/virkeepaliveprotocol.x |    7 +++++++
>  3 files changed, 22 insertions(+), 5 deletions(-)
>  create mode 100644 src/rpc/virkeepaliveprotocol.x

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]