[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 02/13] Implement common keepalive handling



On Thu, Oct 27, 2011 at 06:05:38PM +0200, Jiri Denemark wrote:
> These APIs are used by both client and server RPC layer to handle
> processing of keepalive messages.
> ---
> Notes:
>     Version 3 was ACKed provided I cleare some things up (which I believe I did
>     in v4). I also tried to get the bonus points :-)
> 
>     Version 4:
>     - s/KEEPALIVE_VERSION/KEEPALIVE_PROTOCOL_VERSION/
>     - always free message in virKeepAliveSend
>     - free ka->response in virKeepAliveStop
>     - systemtap probes
>     
>     Version 3:
>     - remove ADVERTISE message handling
>     
>     Version 2:
>     - no change
> 
>  po/POTFILES.in         |    1 +
>  src/Makefile.am        |    3 +-
>  src/probes.d           |   12 ++
>  src/rpc/virkeepalive.c |  448 ++++++++++++++++++++++++++++++++++++++++++++++++
>  src/rpc/virkeepalive.h |   56 ++++++
>  5 files changed, 519 insertions(+), 1 deletions(-)
>  create mode 100644 src/rpc/virkeepalive.c
>  create mode 100644 src/rpc/virkeepalive.h

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]