[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] lxc: plug memory leak



On 09.11.2011 07:51, ajia redhat com wrote:
> From: Alex Jia <ajia redhat com>
> 
> Detected by Coverity. Leak introduced in commit 0f31f7b.
> 
> * src/lxc/lxc_driver.c: Clean up on failure.
> 
> Signed-off-by: Alex Jia <ajia redhat com>
> ---
>  src/lxc/lxc_driver.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
> index 37092bc..a1d0a7c 100644
> --- a/src/lxc/lxc_driver.c
> +++ b/src/lxc/lxc_driver.c
> @@ -1850,6 +1850,7 @@ cleanup:
>      }
>      for (i = 0 ; i < nttyFDs ; i++)
>          VIR_FORCE_CLOSE(ttyFDs[i]);
> +    VIR_FREE(ttyFDs);
>      VIR_FORCE_CLOSE(handshakefds[0]);
>      VIR_FORCE_CLOSE(handshakefds[1]);
>      VIR_FREE(logfile);

ACKed and pushed

I've changed the title to:

lxc: free 'ttyFDs' array on return from lxcVmStart

as you've sent 2 patches with same title, and I think new title express
better what has changed.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]