[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 03/33] Rename all brXXXX APIs to follow new convention



On Tue, Nov 08, 2011 at 09:17:21AM -0500, Stefan Berger wrote:
> On 11/03/2011 01:29 PM, Daniel P. Berrange wrote:
> >From: "Daniel P. Berrange"<berrange redhat com>
> >
> >The existing brXXX APIs in src/util/bridge.h are renamed to
> >follow one of three different conventions
> >
> >  - virNetDevXXX       - operations for any type of interface
> >  - virNetDevBridgeXXX - operations for bridge interfaces
> >  - virNetDevTapXXX    - operations for tap interfaces
> >
> >* src/util/bridge.h, src/util/bridge.c: Rename all APIs
> >* src/lxc/lxc_driver.c, src/network/bridge_driver.c,
> >   src/qemu/qemu_command.c, src/uml/uml_conf.c,
> >   src/uml/uml_driver.c: Update for API renaming
> >---
> >  src/lxc/lxc_driver.c        |    2 +-
> >  src/network/bridge_driver.c |   32 ++++----
> >  src/qemu/qemu_command.c     |    4 +-
> >  src/uml/uml_conf.c          |    4 +-
> >  src/uml/uml_driver.c        |    2 +-
> >  src/util/bridge.c           |  196 +++++++++++++++++++-----------------------
> >  src/util/bridge.h           |   74 ++++++++--------
> >  7 files changed, 148 insertions(+), 166 deletions(-)

> >      ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK;
> >
> >-int     brAddInetAddress        (const char *ifname,
> >-                                 virSocketAddr *addr,
> >-                                 unsigned int prefix)
> >+int virNetDevSetIPv4Addres(const char *ifname,
> Addres->Address

Yes, and i've fixed it in later patches in the series where we move
the functions to new files too.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]