[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/33] Turn two int parameters into bools in bridge APIs



On Tue, Nov 08, 2011 at 09:21:19AM -0500, Stefan Berger wrote:
> On 11/03/2011 01:30 PM, Daniel P. Berrange wrote:
> >From: "Daniel P. Berrange"<berrange redhat com>
> >
> >* src/util/bridge.c, src/util/bridge.h: s/int/bool/ in
> >   virNetDevSetOnline and virNetDevBridgeSetSTP
> >---
> >  src/util/bridge.c |   18 +++++++++---------
> >  src/util/bridge.h |    8 ++++----
> >  2 files changed, 13 insertions(+), 13 deletions(-)

> >@@ -98,10 +98,10 @@ int virNetDevBridgeGetSTPDelay(const char *brname,
> >                                 int *delay)
> >      ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK;
> >  int virNetDevBridgeSetSTP(const char *brname,
> >-                          int enable)
> >+                          bool enable)
> >      ATTRIBUTE_NONNULL(1) ATTRIBUTE_RETURN_CHECK;
> >  int virNetDevBridgeGetSTP(const char *brname,
> >-                          int *enable)
> >+                          bool *enable)
> >      ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK;
> >
> >  int virNetDevTapCreate(char **ifname,
> Hm, would have thought to see the callers being changed as well...

Yes, there was one caller which needed to change from 0/1 to false/true

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]