[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [test-API][PATCH 2/3] "clean" keyword update in libvirt-test-api, mapper, proxy part



On 11/10/2011 11:25 AM, Guannan Sun wrote:
NACK

----- Original Message -----
From: "Guannan Ren"<gren redhat com>
To: libvir-list redhat com
Sent: Wednesday, November 9, 2011 12:38:38 PM
Subject: [libvirt] [test-API][PATCH 2/3] "clean" keyword update in	libvirt-test-api, mapper, proxy part

---
  libvirt-test-api.py |    7 +++++++
  mapper.py           |   24 +++++++++++++++++++-----
  proxy.py            |   13 +++++++++----
  3 files changed, 35 insertions(+), 9 deletions(-)

diff --git a/libvirt-test-api.py b/libvirt-test-api.py
index 8a4bacd..171e13c 100644
--- a/libvirt-test-api.py
+++ b/libvirt-test-api.py
@@ -100,13 +100,20 @@ class LibvirtTestAPI(object):
          # extract the string of combination of
          # language, package, testname of a testcase.
          all_testcases_names = []
+        prev_casename = ''
          for activity in activities_list:
              for testcase in activity:
                  testcases_names = testcase.keys()
                  if 'sleep' in testcases_names:
                      testcases_names.remove('sleep')
+                if not cmp('clean', testcases_names[0]):
+                    all_testcases_names += [prev_casename + ":_clean"]
+                    continue
+
+                prev_casename = testcases_names[0]
                  all_testcases_names += testcases_names

+
          unique_testcases_names = list(set(all_testcases_names))

          # call and initilize proxy component to
diff --git a/mapper.py b/mapper.py
index 4f41230..affc510 100644
--- a/mapper.py
+++ b/mapper.py
@@ -24,20 +24,34 @@ class Mapper(object):
      def __init__(self, testcases_list):
          self.testcases_list = copy.deepcopy(testcases_list)

-    def get_package_tripped(self):
+    def package_casename_func_map(self):


^^^
The change of function name will cause problem when options cleanup enabled in test conf files, function name should also be udpated in env_clear.py
After update function name in env_clear.py, another problem came out which the whole case will be rerun in cleanup process.
So, update needed.


Yes, the code for keyword "cleanup" is still not updated after changing the way of referencing test function.
        I will send  patches later.
        Thanks.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]