[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 12/37] Add more GVirConfigOs setters



Hi

Please merge with previous patch.

> +    if (enable)
> +        xmlNewProp(node, (xmlChar*)"enable", (xmlChar*)"yes");
> +    else
> +        xmlNewProp(node, (xmlChar*)"enable", (xmlChar*)"no");
> +}

might be useful to have use a gchar * gvir_config_yes_no (bool condition)

> +        if (strcmp("boot", (char *)node->name) == 0) {

It could use the safer g_strcmp0.


-- 
Marc-André Lureau


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]