[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 33/37] Implement gvir_config_device_chardev_set_source



On Thu, Nov 10, 2011 at 9:34 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> +    source_type = gvir_config_chardev_source_class_get_nick(G_OBJECT_TYPE(source));
>

I don't see why this is necessarily a class method, I virtual method
would have the same result (but simpler to use).

I don't understand the design of it either. Why not have the chardev
type as a chardev property? Why should the child node set it when it
is parented?


-- 
Marc-André Lureau


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]