[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH libvirt-glib 2/3] Add GVirDomainInterface



On Thu, Nov 10, 2011 at 04:15:01PM -0500, Marc-André Lureau wrote:
> > On Thu, Nov 10, 2011 at 09:33:42PM +0100, Marc-André Lureau wrote:
> > Do we really need to use GSlice here? I consider GSlice as something
> > to use
> > when you want to make many allocations of same-size objects, will we
> > allocate many of these stats objects?
> 
> Yes, it's frequently allocated (1/second), and kept in memory too for history.

Ok, fine with me then.

> > * how do we handle ABI compatibility the day we need to add fields to
> > this
> >   struct?
> 
> It's only a returned structure, allocated by the lib, so I guess that's
> fine to append fields later, right?

Yes, I think it should be fine, I think it's possible to find scenarios
that could break when adding fields, but that's probably some convoluted
cases where we can say "don't do that". Iirc libvirt does this too, so this
should be good enough for us :)

Christophe

Attachment: pgpo5fZkHnU7N.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]