[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH libvirt-glib 1/3] Add GVirDomainDevice abstract class



Hey,

On Thu, Nov 10, 2011 at 04:10:32PM -0500, Marc-André Lureau wrote:
> ----- Mensaje original -----
> > > +G_GNUC_INTERNAL
> > > +virDomainPtr gvir_domain_device_get_domain_handle(GVirDomainDevice
> > > *self)
> > 
> > G_GNUC_INTERNAL isn't needed here since it's the default setting for
> > symbols not listed in the .sym file.
> > 
> 
> I think it's better to be explicit about it. It's a way to declare in the
> code that this function is private, without having to look into the sym
> file. I wish we could do the same for the rest of the prviate functions.

Given that having it or not will have exactly the same result, I have
doubts we'll consistently mark all private functions with G_GNUC_INTERNAL.
Only having some of the private functions marked with it, and the others
without the marking will only create more confusion.
If we are careful about marking all private functions with G_GNUC_INTERNAL,
then why not.

Christophe

Attachment: pgplhfomFXJVH.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]