[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 04/37] Add some GVirConfigClock setters



On Tue, Nov 15, 2011 at 2:37 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> g_return_if_fail(klock != NULL);

I think better is:
g_return_if_fail(GVIR_IS_CONFIG_CLOCK(klock));

> libxml2 provides http://xmlsoft.org/html/libxml-xmlstring.html#BAD_CAST
> which isn't really easy on the eyes. I've got more patches which are not
> ready for review yet, but which move these casts in only a few helper
> functions instead of having them everywhere. If you don't mind, I'll
> address this when all these patches have been sent, is it ok?

sure

-- 
Marc-André Lureau


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]