[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 29/37] Add GVirConfigDeviceInput



On Fri, Nov 11, 2011 at 08:32:30PM +0100, Marc-André Lureau wrote:
> just a comment about naming.
> 
> If we use prefix "Device" before devices class, I think it should be
> done for the rest of the class for consistency.

What are you referring to? GVirConfigGraphicsSpice and GVirConfigInterface?

> > +void gvir_config_device_input_set_bus(GVirConfigDeviceInput *input,
> > +                                      const char *bus)
> > +{
> > +    xmlNodePtr node;
> > +
> > +    node = gvir_config_object_get_xml_node(GVIR_CONFIG_OBJECT(input));
> > +    if (node == NULL)
> > +        return;
> > +    xmlNewProp(node, (xmlChar*)"bus", (xmlChar*)bus);
> > +}
> 
> The bus argument could be an enum too ("xen" (paravirtualized), "ps2" and "usb")

Ok.

Christophe

Attachment: pgpR8qW48ieJx.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]