[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix build with polkit0



On Tue, Nov 15, 2011 at 03:39:28PM -0700, Jim Fehlig wrote:
> I missed adding libvirt_driver_remote.la to libvirtd_LDADD in
> commit b8adfcc6, which didn't cause a problem in 0.9.6 but
> results in this build error in 0.9.7
> 
> libvirtd-remote.o: In function `remoteDispatchAuthPolkit':
> remote.c:(.text+0x188dd): undefined reference to `virNetServerGetDBusConn'
> ---
>  daemon/Makefile.am |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/daemon/Makefile.am b/daemon/Makefile.am
> index e8c47ae..59db217 100644
> --- a/daemon/Makefile.am
> +++ b/daemon/Makefile.am
> @@ -156,6 +156,10 @@ endif
>  if WITH_NWFILTER
>      libvirtd_LDADD += ../src/libvirt_driver_nwfilter.la
>  endif
> +
> +if HAVE_POLKIT0
> +    libvirtd_LDADD += ../src/libvirt_driver_remote.la
> +endif

NACK this is wrong - it is already linked to libvirt.so, which is
linked to libvirtd, so tthis results in 2 copies of the code linked.
What is missing here is likely the entry for virNetServerGetDBusConn
in libvirt_private.syms

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]