[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] fix a bug in remoteSerializeTypedParameters



On 11/16/2011 01:38 AM, Hu Tao wrote:
> This is a fatal typo believed to be very likely to happen when using
> both i and j at the same time for indexing.

Yep, and thanks for catching it.

> ---
>  daemon/remote.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/daemon/remote.c b/daemon/remote.c
> index 857835e..97c9538 100644
> --- a/daemon/remote.c
> +++ b/daemon/remote.c
> @@ -710,7 +710,7 @@ remoteSerializeTypedParameters(virTypedParameterPtr params,
>              goto cleanup;
>          }
>          val[j].value.type = params[i].type;
> -        switch (params[j].type) {
> +        switch (params[i].type) {

ACK and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]