[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 01/16] Rename Macvtap management APIs



On 11/15/2011 06:14 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"<berrange redhat com>

In preparation for code re-organization, rename the Macvtap
management APIs to have the following patterns

   virNetDevMacVLanXXXXX     - macvlan/macvtap interface management
   virNetDevVPortProfileXXXX - virtual port profile management

* src/util/macvtap.c, src/util/macvtap.h: Rename APIs
* src/conf/domain_conf.c, src/network/bridge_driver.c,
   src/qemu/qemu_command.c, src/qemu/qemu_command.h,
   src/qemu/qemu_driver.c, src/qemu/qemu_hotplug.c,
   src/qemu/qemu_migration.c, src/qemu/qemu_process.c,
   src/qemu/qemu_process.h: Update for renamed APIs
---
  src/conf/domain_conf.c      |   10 +-
  src/libvirt_private.syms    |    4 +-
  src/network/bridge_driver.c |    8 +-
  src/qemu/qemu_command.c     |   20 +-
  src/qemu/qemu_command.h     |    4 +-
  src/qemu/qemu_driver.c      |   12 +-
  src/qemu/qemu_hotplug.c     |   12 +-
  src/qemu/qemu_migration.c   |   24 ++--
  src/qemu/qemu_process.c     |   12 +-
  src/qemu/qemu_process.h     |    2 +-
  src/util/macvtap.c          |  388 ++++++++++++++++++++++---------------------
  src/util/macvtap.h          |  100 ++++++-----
  tests/qemuxml2argvtest.c    |    2 +-
  tests/qemuxmlnstest.c       |    2 +-
  14 files changed, 308 insertions(+), 292 deletions(-)

(unless otherwise noted, all of my reviews in this series included a successful run of make && make check && make syntax-check)

Looks fairly mechanical. ACK.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]