[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 01/11] don't modify CPU set string in virDomainCpuSetParse

From: Bharata B Rao <bharata linux vnet ibm com>
To: Hu Tao <hutao cn fujitsu com>
Cc: libvir-list redhat com
Subject: Re: [libvirt] [PATCHv2 01/11] don't modify CPU set string in virDomainCpuSetParse
Date: Fri, 18 Nov 2011 13:12:54 +0530

On Thu, Nov 17, 2011 at 05:44:11PM +0800, Hu Tao wrote:
> As the function only parses the CPU set string, there is
> no good reason to modify it.

- You need to reflect this change in the comment too.
- My patchset for guest NUMA specification which uses virDomainCpuSetParse()
  is upstream now. The call site in virCPUDefParseXML() can be simplified
  after this change.

Regards,
Bharata.

Follow-Ups:
- [libvirt] [PATCHv3] conf: don't modify cpu set string during parsing
  - From: Eric Blake

References:
- [libvirt] [RFC][PATCHv2 00/11] add numatune command
  - From: Hu Tao
- [libvirt] [PATCHv2 01/11] don't modify CPU set string in virDomainCpuSetParse
  - From: Hu Tao

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]