[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 07/11] add new API virDomain{G, S}etNumaParameters



On Thu, Nov 17, 2011 at 05:44:17PM +0800, Hu Tao wrote:
> Set up the types for the numa functions and insert them into the
> virDriver structure definition.
> ---
>  include/libvirt/libvirt.h.in |   23 +++++++++++++++++++++++
>  python/generator.py          |    2 ++
>  src/driver.h                 |   15 +++++++++++++++
>  src/libvirt_public.syms      |    6 ++++++
>  4 files changed, 46 insertions(+), 0 deletions(-)
> 
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index 2ab89f5..7ce6352 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -1311,6 +1311,29 @@ typedef enum {
>  } virDomainMemoryModFlags;
>  
>  
> +/* Manage numa parameters */
> +
> +/**
> + * VIR_DOMAIN_NUMA_NODESET:
> + *
> + * numa nodeset
> + */
> +#define VIR_DOMAIN_NUMA_NODESET "numa_nodeset"
> +
> +/**
> + * VIR_DOMAIN_NUMA_MODE:
> + *
> + * numa mode
> + */
> +#define VIR_DOMAIN_NUMA_MODE "numa_mode"
> +
> +int     virDomainSetNumaParameters(virDomainPtr domain,
> +                                   virTypedParameterPtr params,
> +                                   int nparams, unsigned int flags);
> +int     virDomainGetNumaParameters(virDomainPtr domain,
> +                                   virTypedParameterPtr params,
> +                                   int *nparams, unsigned int flags);

IMHO, we should really have an API more like the CPU pinning API
for controlling numa placement. eg the API accepts a bitmap of
allowed nodes.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]