[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 06/11] add VIR_DOMAIN_NUMATUNE_MEM_NONE



On Thu, Nov 17, 2011 at 05:44:16PM +0800, Hu Tao wrote:
> add VIR_DOMAIN_NUMATUNE_MEM_NONE to represent none of the numatune
> modes is set
> ---
>  src/conf/domain_conf.c |    1 +
>  src/conf/domain_conf.h |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 71eb209..6150b10 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -587,6 +587,7 @@ VIR_ENUM_IMPL(virDomainTimerMode, VIR_DOMAIN_TIMER_MODE_LAST,
>                "smpsafe");
>  
>  VIR_ENUM_IMPL(virDomainNumatuneMemMode, VIR_DOMAIN_NUMATUNE_MEM_LAST,
> +              "none",
>                "strict",
>                "preferred",
>                "interleave");
> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index 29ac165..1b8b15c 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -1345,6 +1345,7 @@ virDomainVcpuPinDefPtr virDomainVcpuPinFindByVcpu(virDomainVcpuPinDefPtr *def,
>                                                    int vcpu);
>  
>  enum virDomainNumatuneMemMode {
> +    VIR_DOMAIN_NUMATUNE_MEM_NONE,
>      VIR_DOMAIN_NUMATUNE_MEM_STRICT,
>      VIR_DOMAIN_NUMATUNE_MEM_PREFERRED,
>      VIR_DOMAIN_NUMATUNE_MEM_INTERLEAVE,

I don't see any purpose for this addition. The three options we have there
already suit all needs AFAICT.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]