[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [virt-tools-list] [osinfo PATCH 1/8] Add #include <string.h> for strcmp



On Fri, Nov 18, 2011 at 11:26:21AM -0700, Eric Blake wrote:
> [adding virt-tools-list]
> 
> On 11/18/2011 11:04 AM, Christophe Fergeau wrote:
> > ---
> >  tools/osinfo-detect.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/tools/osinfo-detect.c b/tools/osinfo-detect.c
> > index 6afa30a..be36afb 100644
> > --- a/tools/osinfo-detect.c
> > +++ b/tools/osinfo-detect.c
> > @@ -23,6 +23,7 @@
> >   */
> >  
> >  #include <osinfo/osinfo.h>
> > +#include <string.h>
> 
> I've typically seen libosinfo patches sent to
> virt-tools-list redhat com   However, I just glanced through README in
> libosinfo.git and didn't see any mention of the preferred address for
> patch submission, nor mention of a project web page.  Those would be
> some useful patches, to help steer further patches to the best list.

I'll change the README for that.

> As to patch 1/8, it's trivial enough that I can ACK, even if I haven't
> done anything else with libosinfo myself (I'll leave others to review
> the rest of the series).

ACK to all the other patches too

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]