[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 11/37] Implement gvir_config_os_set_os_type



Hey,

On Tue, Nov 15, 2011 at 03:33:45PM +0100, Marc-André Lureau wrote:
> However, thinking a bit more about it, genum_get_nick() shouldn't warn
> if given a value that has no associated nick, because enums shouldn't
> be limited to their associated name, and those value would be
> perfectly valid, but should return NULL and that's it.

For now I have added a warning to genum_get_nick since we shouldn't get an
enum with no associated strings. If this happens, this means something
unexpected happened, so it's better to warn about it. We can change this
when we have a valid use case for this.

> 
> However, siliently not doing anything is misleading. So instead of
> 
> if (type_str != NULL)
>   xmlNodeSetContent(node, (xmlChar*)type_str);
> 
> I would do (or similar):
> 
> g_return_if_fail (type_str != NULL);
> xmlNodeSetContent(node, (xmlChar*)type_str);

And I did that change too.

Christophe

Attachment: pgpeB4mAya1OJ.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]