[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain



On Mon, Nov 21, 2011 at 9:27 PM, Marc-André Lureau
<marcandre lureau gmail com> wrote:
> Hi
>
> On Mon, Nov 21, 2011 at 6:53 PM, Zeeshan Ali (Khattak)
> <zeeshanak gnome org> wrote:
>> +    g_return_val_if_fail(error == NULL || *error == NULL, FALSE);
>
> This is wrong, it should be error != NULL && *error == NULL.
>
>> +    if (virDomainDefineXML(conn, xml) == NULL) {
>> +        if (error != NULL)
>> +            *error = gvir_error_new_literal(GVIR_DOMAIN_ERROR,
>> +                                            0,
>> +                                            "Failed to set "
>> +                                            "domain configuration");
>> +        return FALSE;
>> +   }
>
> Can you please verify that the return value is safe to ignore?

  Sorry, i don't get it. Verify how?

> I would really prefer we add a runtime check that verifiy the handle
> is the same as the one currently associated with the domain.

  Yeah, i'll add that! Forgot that it still applies.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]