[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Bug Fix: Do not release network actual device in qemuBuildCommandLine on error



That's a long subject line; I shortened it to:

qemu: don't release network actual device twice

On 11/16/2011 07:34 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu <roprabhu cisco com>
> 
> For direct attach devices, in qemuBuildCommandLine, we seem to be freeing
> actual device on error path (with networkReleaseActualDevice). But the actual
> device is not deleted.
> 
> qemuProcessStop eventually deletes the direct attach device and releases actual device. But by the time qemuProcessStop is called qemuBuildCommandLine
> has already freed actual device. Leaving stray macvtap devices behind on error.
> So the simplest fix is to remove the networkReleaseActualDevice in
> qemuBuildCommandLine. This patch does just that.
> 
> Does this look right ?. I have only verified this with direct and bridge mode.

as well as filtering the uncertainty out of the commit message.

> 
> The other option is to do both delMacvtap and networkReleaseActualDevice in
> qemuBuildCommandLine instead of doing only networkReleaseActualDevice.
> I do have a patch for this too.
> 
> Signed-off-by: Roopa Prabhu <roprabhu cisco com>
> ---
>  src/qemu/qemu_command.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)

Given Stefan's testing, ACK and pushed with commit message modified per
above.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]