[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH V1 6/9] Add test cases for STP traffic filtering



On 10/26/2011 09:12 AM, Stefan Berger wrote:
> This patch adds a few test cases for the XML parsing of STP filtering nodes.
> 
> Signed-off-by: Stefan Berger <stefanb linux vnet ibm com>
> 
> ---
>  tests/nwfilterxml2xmlin/stp-test.xml  |   26 ++++++++++++++++++++++++++
>  tests/nwfilterxml2xmlout/stp-test.xml |   12 ++++++++++++
>  tests/nwfilterxml2xmltest.c           |    1 +
>  3 files changed, 39 insertions(+)

Looks good.  ACK.

> +  <rule action='reject' direction='in'>
> +     <stp srcmacaddr='1:2:3:4:5:6' srcmacmask='ff:ff:ff:ff:ff:ff'
> +          sender-priority='0x1234'
> +          sender-address="6:5:4:3:2:1"
> +          port='123' port-hi='234'
> +          age='5544' age-hi='5555'
> +          max-age='7777'  max-age-hi='8888'
> +          hello-time='12345' hello-time-hi='12346'
> +          forward-delay='54321' forward-delay-hi='65432'/>

That's a lot of attributes for one element, thankfully we can split it
over multiple lines.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]