[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC PATCH v2 1/4] PowerPC : Use Sysfs to gather host topology



On 11/14/2011 07:46 AM, Prerna Saxena wrote:
>>From 9084802bdf7a2c10d6a913cb7dde001ab6ab3543 Mon Sep 17 00:00:00 2001
> From: Prerna Saxena <prerna linux vnet ibm com>
> Date: Mon, 3 Oct 2011 05:45:30 -0700
> Subject: [PATCH 1/4] Use sysfs to gather host topology, in place of
>  /proc/cpuinfo

Are we sure that sysfs has this information for all kernels as far back
as RHEL 5?  Or should this patch be doing conditionals; probing sysfs
first but falling back to /proc/cpuinfo otherwise?

I tried compiling things, but got this warning:

nodeinfo.c: In function 'linuxNodeInfoCPUPopulate':
nodeinfo.c:287:5: error: suggest parentheses around assignment used as
truth value [-Werror=parentheses]
nodeinfo.c:202:36: error: unused parameter 'need_hyperthreads'
[-Werror=unused-parameter]

and seeing other comments in this thread, I didn't review it very
closely (this is more a chance to revive the thread after a week, to see
if you are planning on a resubmission before we consider a freeze for
0.9.8).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]