[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-gconfig PATCHv2 08/32] Add gvir_config_domain_set_clock



On Tue, Nov 22, 2011 at 12:56:02PM +0000, Daniel P. Berrange wrote:
> On Mon, Nov 21, 2011 at 07:04:05PM +0100, Christophe Fergeau wrote:
> > The implementation is likely to need to be completed later. We
> > might want to store pointers from GVirConfigDomain to the associated
> > GVirConfigClock, from GVirConfigClock to the GVirConfigDomain that
> > contains it. Since I'm not sure yet if they will be needed, I chose
> > to keep the implementation simple.
> > 
> > --
> > v2: use g_return_if_fail to test function args for sanity
> > ---
> >  libvirt-gconfig/libvirt-gconfig-domain.c |   12 ++++++++++++
> >  libvirt-gconfig/libvirt-gconfig-domain.h |    2 ++
> >  libvirt-gconfig/libvirt-gconfig.sym      |    1 +
> >  3 files changed, 15 insertions(+), 0 deletions(-)
> 
> ACK
> 
> > diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym
> > index c3d46d5..7b346a1 100644
> > --- a/libvirt-gconfig/libvirt-gconfig.sym
> > +++ b/libvirt-gconfig/libvirt-gconfig.sym
> > @@ -13,6 +13,7 @@ LIBVIRT_GOBJECT_0.0.1 {
> >  	gvir_config_domain_get_type;
> >  	gvir_config_domain_new;
> >  	gvir_config_domain_new_from_xml;
> > +	gvir_config_domain_set_clock;
> >  	gvir_config_domain_get_features;
> >  	gvir_config_domain_set_features;
> >  	gvir_config_domain_get_memory;
> 
> We should start a LIBVIRT_GOBJECT_0.0.2 block for symbols now 0.0.1 is
> released.

On second thought, we could just rename the existing symbol version
block. Since we are explicitly not ABI stable, renaming the block
will force an application rebuild which is desirable for now

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]