[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-gconfig PATCHv2 25/32] GVirConfigInterface derives from GVirConfigDevice



On Mon, Nov 21, 2011 at 07:04:22PM +0100, Christophe Fergeau wrote:
> This base class is mainly useful as a generic type when we manipulate
> list of devices regardless of their actual type.
> ---
>  libvirt-gconfig/libvirt-gconfig-interface.c |    2 +-
>  libvirt-gconfig/libvirt-gconfig-interface.h |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

Hmm, I don't believe this is correct.  GVirConfigInterface is a top level
XML document used for the GVirInterface object in libvirt.

NB, not to be confused with the GVirConfigDomainInterface which is a device
element within the GVirConfigDomain XML document.

So NACK to this

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]