[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-gconfig PATCHv2 32/32] Add GVirConfigDeviceVideo



On Mon, Nov 21, 2011 at 07:04:29PM +0100, Christophe Fergeau wrote:
> --
> v2: use g_return_if_fail to test function args for sanity
> ---
>  libvirt-gconfig/Makefile.am                    |    2 +
>  libvirt-gconfig/libvirt-gconfig-device-video.c |  133 ++++++++++++++++++++++++
>  libvirt-gconfig/libvirt-gconfig-device-video.h |   82 +++++++++++++++
>  libvirt-gconfig/libvirt-gconfig.h              |    1 +
>  libvirt-gconfig/libvirt-gconfig.sym            |    8 ++
>  libvirt-gconfig/tests/test-domain-create.c     |    9 ++
>  6 files changed, 235 insertions(+), 0 deletions(-)
>  create mode 100644 libvirt-gconfig/libvirt-gconfig-device-video.c
>  create mode 100644 libvirt-gconfig/libvirt-gconfig-device-video.h
> 
> diff --git a/libvirt-gconfig/Makefile.am b/libvirt-gconfig/Makefile.am
> index 1be6233..05cdbd0 100644
> --- a/libvirt-gconfig/Makefile.am
> +++ b/libvirt-gconfig/Makefile.am
> @@ -17,6 +17,7 @@ GCONFIG_HEADER_FILES = \
>  			libvirt-gconfig-device-graphics.h \
>  			libvirt-gconfig-device-graphics-spice.h \
>  			libvirt-gconfig-device-input.h \
> +			libvirt-gconfig-device-video.h \
>  			libvirt-gconfig-domain.h \
>  			libvirt-gconfig-domain-snapshot.h \
>  			libvirt-gconfig-helpers.h \
> @@ -42,6 +43,7 @@ GCONFIG_SOURCE_FILES = \
>  			libvirt-gconfig-device-graphics.c \
>  			libvirt-gconfig-device-graphics-spice.c \
>  			libvirt-gconfig-device-input.c \
> +			libvirt-gconfig-device-video.c \
>  			libvirt-gconfig-domain.c \
>  			libvirt-gconfig-domain-snapshot.c \
>  			libvirt-gconfig-enum-types.c \

Looking again at the earlier patches, we have a naming issue here. All
the objects which are used as children of GVirConfigDomain, should
share the same naming prefix, eg  GVirConfigDomainVideo,
GVirConfigDomainGraphics, GVirConfigDomainClock, etc, otherwise we will
end up having significant namespace clashes with elements from other
XML documents in libvirt.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]