[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain



On Tue, Nov 22, 2011 at 11:20 AM, Daniel P. Berrange
<berrange redhat com> wrote:
> On Mon, Nov 21, 2011 at 08:27:17PM +0100, Marc-André Lureau wrote:
>> Hi
>>
>> On Mon, Nov 21, 2011 at 6:53 PM, Zeeshan Ali (Khattak)
>> <zeeshanak gnome org> wrote:
>> > +    g_return_val_if_fail(error == NULL || *error == NULL, FALSE);
>>
>> This is wrong, it should be error != NULL && *error == NULL.
>>
>> > +    if (virDomainDefineXML(conn, xml) == NULL) {
>> > +        if (error != NULL)
>> > +            *error = gvir_error_new_literal(GVIR_DOMAIN_ERROR,
>> > +                                            0,
>> > +                                            "Failed to set "
>> > +                                            "domain configuration");
>> > +        return FALSE;
>> > +   }
>>
>> Can you please verify that the return value is safe to ignore?
>>
>> I would really prefer we add a runtime check that verifiy the handle
>> is the same as the one currently associated with the domain.
>
> The actual pointer returned will *not* be the same as the same
> one you currently have, but assuming the XML has matching UUID
> and name, it will point to the same domain.
>
> So I guess what you want todo is verify the UUID and name in
> the XML, before defining it.
>
> Also, you need to call virDomainFree on the return value of
> virDomainDefineXML to avoid memleak.

   Thanks! I already pushed the patch that does this and Marc-Andre ack'ed.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]