[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH libvirt-glib 1/5] Add support for writing to streams



On Tue, Nov 22, 2011 at 02:50:26PM +0100, Christophe Fergeau wrote:
> On Tue, Nov 22, 2011 at 12:39:28PM +0000, Daniel P. Berrange wrote:
> > +
> > +GType                _gvir_output_stream_get_type                 (void) G_GNUC_CONST;
> > +GVirOutputStream *   _gvir_output_stream_new                      (GVirStream *stream);
> 
> This brings the question of how to mark functions that are internal to the
> library. Marc-André is in favour of using G_GNUC_INTERNAL in the function
> definition, you seem to prefer a _ prefix. I like the latter best, but I'd
> be fine with either.

On the contrary. I would gladly get rid of the '_' prefix. I only have it
because the existing gvir_input_stream* functions have it, and when I
tried to remove it, then GTK-DOC tried to generate pages for this type.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]