[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] nwfilter: Initialize virNWFilterAddIpAddrForIfname return variable



On 11/23/2011 05:15 AM, Stefan Berger wrote:
> Thanks for trying to fix this. This one tries to address Jiri's concern
> about the return value from virNWFilterHashTablePut with a not to fix it
> in the future.
> 
> Latest nwfilter patch ad6c67cf introduced uninitialized return
> value. This was spotted by 4.6.2 gcc.
> ---
>  src/nwfilter/nwfilter_learnipaddr.c |   15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)

Quite a bit of traffic on this one :)

Looks like Dan already pushed a shorter stop-gap patch, but ACK if you'd
like to push this one as a more complete version.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]