[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: Properly generate and check virkeepaliveprotocol-structs



On Thu, Nov 24, 2011 at 06:26:50AM -0700, Eric Blake wrote:
> On 11/24/2011 06:18 AM, Jiri Denemark wrote:
> > This fixes make dist broken by recent keepalive series
> > ---
> >  src/Makefile.am |    8 +++++---
> >  1 files changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/src/Makefile.am b/src/Makefile.am
> > index e8f20de..33a32a8 100644
> > --- a/src/Makefile.am
> > +++ b/src/Makefile.am
> > @@ -247,14 +247,15 @@ EXTRA_DIST +=  $(REMOTE_DRIVER_PROTOCOL) \
> >  # The alternation of the following regexps matches both cases.
> >  r1 = /\* \d+ \*/
> >  r2 = /\* <[[:xdigit:]]+> \S+:\d+ \*/
> > +struct_prefix = (remote_|qemu_|virNet|keepalive_)
> 
> Nice factoring to avoid the long line.
> 
> ACK.
> 
> >  		-e 'END {'						\
> > -		-e '  if ($$n < 3) {'					\
> > +		-e '  if ($$n < 1) {'					\
> >  		-e '    warn "WARNING: your pdwtags program is too old\n";' \
> 
> That's now a rather weak test, but I can't think of anything more
> reliable that doesn't also reject keepalive.
> 
> Hmm, I wonder if I should add cppi and pdwtags to my list of required
> maintainer tools in this unreviewed patch:
> https://www.redhat.com/archives/libvir-list/2011-November/msg01052.html
> 
> They would still be optional for tarball builds, of course, but having
> them required when doing autogen.sh on libvirt.git may help more
> developers catch problems up front.

  Wasn't the problem that cppi isn't universaly available ? If that's
the case the status quo while a bit more painful for those whove have
it, avoid a dependance needed to build and submit patches.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]