[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/5] Add support for CPU quota/period to LXC driver



On Thu, Nov 24, 2011 at 10:05:50PM +0800, Daniel Veillard wrote:
> On Thu, Nov 24, 2011 at 11:38:14AM +0000, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange redhat com>
> > 
> > * src/lxc/lxc_driver.c: Support changing quota/period for LXC
> >   containers
> > * src/lxc/lxc_controller.c: Set initial quota/period at startup
> > ---
> >  src/lxc/lxc_controller.c |   49 ++++-
> >  src/lxc/lxc_driver.c     |  463 ++++++++++++++++++++++++++++++++++++++++-----
> >  2 files changed, 450 insertions(+), 62 deletions(-)


>   ACK, It tried to look if some of that code could not be moved as
>   generic one under utils/cgroup.[ch] but it's not that easy to
> share with qemu driver, doesn't seems one would gain much

It can't really go into utils/cgroup.[ch], but I think there is scope
for creating a shared API in src/conf/domain_cgroup.[ch], like we did
for domain_audit.[ch]. To be investigated later...


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]