[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH v5 3/4] Implement the core API to suspend/resume the host



Add the core functions that implement the functionality of the API.
Suspend is done by using an asynchronous mechanism so that we can return
the status to the caller before the host gets suspended. This asynchronous
operation is achieved by suspending the host in a separate thread of
execution. However, returning the status to the caller is only best-effort,
but not guaranteed.

To resume the host, an RTC alarm is set up (based on how long we want to
suspend) before suspending the host. When this alarm fires, the host gets
woken up.

Suspend-to-RAM operation on a host running Linux can take upto more than 20
seconds, depending on the load of the system. (Freezing of tasks, an operation
preceding any suspend operation, is given up after a 20 second timeout).
And Suspend-to-Disk can take even more time, considering the time required
for compaction, creating the memory image and writing it to disk etc.
So, we do not allow the user to specify a suspend duration of less than 60
seconds, to be on the safer side, since we don't want to prematurely declare
failure when we only had to wait for some more time.

Signed-off-by: Srivatsa S. Bhat <srivatsa bhat linux vnet ibm com>
---

 src/Makefile.am           |    1 
 src/libvirt.c             |    4 +
 src/libvirt_private.syms  |    5 +
 src/lxc/lxc_driver.c      |    2 
 src/qemu/qemu_driver.c    |    2 
 src/uml/uml_driver.c      |    2 
 src/util/virnodesuspend.c |  269 +++++++++++++++++++++++++++++++++++++++++++++
 src/util/virnodesuspend.h |   36 ++++++
 src/xen/xen_driver.c      |    2 
 9 files changed, 322 insertions(+), 1 deletions(-)
 create mode 100644 src/util/virnodesuspend.c
 create mode 100644 src/util/virnodesuspend.h

diff --git a/src/Makefile.am b/src/Makefile.am
index 252c64f..762c6a7 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -85,6 +85,7 @@ UTIL_SOURCES =							\
 		util/util.c util/util.h				\
 		util/viraudit.c util/viraudit.h			\
 		util/virfile.c util/virfile.h			\
+		util/virnodesuspend.c util/virnodesuspend.h	\
 		util/virpidfile.c util/virpidfile.h		\
 		util/xml.c util/xml.h				\
 		util/virterror.c util/virterror_internal.h	\
diff --git a/src/libvirt.c b/src/libvirt.c
index 7a13b11..626d34b 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -43,6 +43,7 @@
 #include "conf.h"
 #include "rpc/virnettlscontext.h"
 #include "command.h"
+#include "virnodesuspend.h"
 
 #ifndef WITH_DRIVER_MODULES
 # ifdef WITH_TEST
@@ -399,7 +400,8 @@ virInitialize(void)
 
     if (virThreadInitialize() < 0 ||
         virErrorInitialize() < 0 ||
-        virRandomInitialize(time(NULL) ^ getpid()))
+        virRandomInitialize(time(NULL) ^ getpid()) ||
+        virNodeSuspendInit() < 0)
         return -1;
 
     gcry_control(GCRYCTL_SET_THREAD_CBS, &virTLSThreadImpl);
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 2cf50d3..6c08e56 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -1320,6 +1320,11 @@ virNetTLSContextNewServer;
 virNetTLSContextNewServerPath;
 
 
+# virnodesuspend.h
+nodeSuspendForDuration;
+virNodeSuspendInit;
+
+
 # virpidfile.h
 virPidFileAcquire;
 virPidFileAcquirePath;
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index 1110c45..3f52129 100644
--- a/src/lxc/lxc_driver.c
+++ b/src/lxc/lxc_driver.c
@@ -56,6 +56,7 @@
 #include "domain_nwfilter.h"
 #include "network/bridge_driver.h"
 #include "virnetdev.h"
+#include "virnodesuspend.h"
 
 #define VIR_FROM_THIS VIR_FROM_LXC
 
@@ -3273,6 +3274,7 @@ static virDriver lxcDriver = {
     .domainEventRegisterAny = lxcDomainEventRegisterAny, /* 0.8.0 */
     .domainEventDeregisterAny = lxcDomainEventDeregisterAny, /* 0.8.0 */
     .domainOpenConsole = lxcDomainOpenConsole, /* 0.8.6 */
+    .nodeSuspendForDuration = nodeSuspendForDuration, /* 0.9.8 */
 };
 
 static virStateDriver lxcStateDriver = {
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index fe2ab85..16adbaa 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -88,6 +88,7 @@
 #include "locking/lock_manager.h"
 #include "locking/domain_lock.h"
 #include "virkeycode.h"
+#include "virnodesuspend.h"
 
 #define VIR_FROM_THIS VIR_FROM_QEMU
 
@@ -10918,6 +10919,7 @@ static virDriver qemuDriver = {
     .domainGetBlockJobInfo = qemuDomainGetBlockJobInfo, /* 0.9.4 */
     .domainBlockJobSetSpeed = qemuDomainBlockJobSetSpeed, /* 0.9.4 */
     .domainBlockPull = qemuDomainBlockPull, /* 0.9.4 */
+    .nodeSuspendForDuration = nodeSuspendForDuration, /* 0.9.8 */
 };
 
 
diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c
index a0e086a..30e25bf 100644
--- a/src/uml/uml_driver.c
+++ b/src/uml/uml_driver.c
@@ -62,6 +62,7 @@
 #include "fdstream.h"
 #include "configmake.h"
 #include "virnetdevtap.h"
+#include "virnodesuspend.h"
 
 #define VIR_FROM_THIS VIR_FROM_UML
 
@@ -2597,6 +2598,7 @@ static virDriver umlDriver = {
     .domainEventRegisterAny = umlDomainEventRegisterAny, /* 0.9.4 */
     .domainEventDeregisterAny = umlDomainEventDeregisterAny, /* 0.9.4 */
     .domainOpenConsole = umlDomainOpenConsole, /* 0.8.6 */
+    .nodeSuspendForDuration = nodeSuspendForDuration, /* 0.9.8 */
 };
 
 static int
diff --git a/src/util/virnodesuspend.c b/src/util/virnodesuspend.c
new file mode 100644
index 0000000..f095f7d
--- /dev/null
+++ b/src/util/virnodesuspend.c
@@ -0,0 +1,269 @@
+/*
+ * virnodesuspend.c: Support for suspending a node (host machine)
+ *
+ * Copyright (C) 2011 Srivatsa S. Bhat <srivatsa bhat linux vnet ibm com>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
+ *
+ */
+
+#include <config.h>
+#include "virnodesuspend.h"
+
+#include "command.h"
+#include "threads.h"
+#include "datatypes.h"
+
+#include "memory.h"
+#include "logging.h"
+#include "virterror_internal.h"
+
+#define VIR_FROM_THIS VIR_FROM_NONE
+
+#define virNodeSuspendError(code, ...)                                     \
+        virReportErrorHelper(VIR_FROM_NONE, code, __FILE__,                \
+                             __FUNCTION__, __LINE__, __VA_ARGS__)
+
+
+# define SUSPEND_DELAY 10 /* in seconds */
+
+/* Give sufficient time for performing the suspend operation on the host */
+# define MIN_TIME_REQ_FOR_SUSPEND 60 /* in seconds */
+
+/*
+ * Bitmask to hold the Power Management features supported by the host,
+ * such as Suspend-to-RAM, Suspend-to-Disk, Hybrid-Suspend etc.
+ */
+static unsigned int hostPMFeatures;
+
+virMutex virNodeSuspendMutex;
+
+static bool aboutToSuspend;
+
+static void virNodeSuspendLock(void)
+{
+    virMutexLock(&virNodeSuspendMutex);
+}
+
+static void virNodeSuspendUnlock(void)
+{
+    virMutexUnlock(&virNodeSuspendMutex);
+}
+
+
+/**
+ * virNodeSuspendInit:
+ *
+ * Get the system-wide sleep states supported by the host, such as
+ * Suspend-to-RAM, Suspend-to-Disk, or Hybrid-Suspend, so that a request
+ * to suspend/hibernate the host can be handled appropriately based on
+ * this information.
+ *
+ * Returns 0 if successful, and -1 in case of error.
+ */
+int virNodeSuspendInit(void)
+{
+
+    if (virMutexInit(&virNodeSuspendMutex) < 0) 
+        return -1;
+
+    /* Get the power management capabilities supported by the host */
+    if (virGetPMCapabilities(&hostPMFeatures) < 0) {
+        VIR_ERROR(_("Failed to get host power management features"));
+        return -1;
+    }
+
+    return 0;
+}
+
+
+/**
+ * virNodeSuspendSetNodeWakeup:
+ * @alarmTime: time in seconds from now, at which the RTC alarm has to be set.
+ *
+ * Set up the RTC alarm to the specified time.
+ * Return 0 on success, -1 on failure.
+ */
+static int virNodeSuspendSetNodeWakeup(unsigned long long alarmTime)
+{
+    virCommandPtr setAlarmCmd;
+    int ret = -1;
+
+    if (alarmTime <= MIN_TIME_REQ_FOR_SUSPEND) {
+        virNodeSuspendError(VIR_ERR_INVALID_ARG, "%s", _("Suspend duration is too short"));
+        return -1;
+    }
+
+    setAlarmCmd = virCommandNewArgList("rtcwake", "-m", "no", "-s", NULL);
+    virCommandAddArgFormat(setAlarmCmd, "%lld", alarmTime);
+
+    if (virCommandRun(setAlarmCmd, NULL) < 0)
+        goto cleanup;
+
+    ret = 0;
+
+cleanup:
+    virCommandFree(setAlarmCmd);
+    return ret;
+}
+
+/**
+ * virNodeSuspend:
+ * @cmdString: pointer to the command string this thread has to execute.
+ *
+ * Actually perform the suspend operation by invoking the command.
+ * Give a short delay before executing the command so as to give a chance
+ * to virNodeSuspendForDuration() to return the status to the caller.
+ * If we don't give this delay, that function will not be able to return
+ * the status, since the suspend operation would have begun and hence no
+ * data can be sent through the connection to the caller. However, with
+ * this delay added, the status return is best-effort only.
+ */
+static void virNodeSuspend(void *cmdString)
+{
+    virCommandPtr suspendCmd = virCommandNew((char *)cmdString);
+
+    VIR_FREE(cmdString);
+
+    /*
+     * Delay for sometime so that the function nodeSuspendForDuration()
+     * can return the status to the caller.
+     */
+    sleep(SUSPEND_DELAY);
+    if (virCommandRun(suspendCmd, NULL) < 0)
+        VIR_WARN("Failed to suspend the host");
+
+    virCommandFree(suspendCmd);
+
+    /*
+     * Now that we have resumed from suspend or the suspend failed,
+     * reset 'aboutToSuspend' flag.
+     */
+    virNodeSuspendLock();
+    aboutToSuspend = false;
+    virNodeSuspendUnlock();
+}
+
+/**
+ * nodeSuspendForDuration:
+ * @conn: pointer to the hypervisor connection
+ * @target: the state to which the host must be suspended to -
+ *         VIR_NODE_SUSPEND_TARGET_MEM       (Suspend-to-RAM),
+ *         VIR_NODE_SUSPEND_TARGET_DISK      (Suspend-to-Disk),
+ *         VIR_NODE_SUSPEND_TARGET_HYBRID    (Hybrid-Suspend)
+ * @duration: the time duration in seconds, for which the host must be
+ *            suspended
+ * @flags: any flag values that might need to be passed; currently unused.
+ *
+ * Suspend the node (host machine) for the given duration of time in the
+ * specified state (such as Mem, Disk or Hybrid-Suspend). Attempt to resume
+ * the node after the time duration is complete.
+ *
+ * First, an RTC alarm is set appropriately to wake up the node from its
+ * sleep state. Then the actual node suspend operation is carried out
+ * asynchronously in another thread, after a short time delay so as to
+ * give enough time for this function to return status to its caller
+ * through the connection. However this returning of status is best-effort
+ * only, and should generally happen due to the short delay but might be
+ * missed if the machine suspends first.
+ *
+ * Returns 0 in case the node is going to be suspended after a short delay,
+ * -1 if suspending the node is not supported, or if a previous suspend
+ * operation is still in progress.
+ */
+int nodeSuspendForDuration(virConnectPtr conn ATTRIBUTE_UNUSED,
+                           unsigned int target,
+                           unsigned long long duration,
+                           unsigned int flags ATTRIBUTE_UNUSED)
+{
+    static virThread thread;
+    char *cmdString = NULL;
+
+    /*
+     * Ensure that we are the only ones trying to suspend.
+     * Fail if somebody has already initiated a suspend.
+     */
+    virNodeSuspendLock();
+
+    if (aboutToSuspend) {
+        /* A suspend operation is already in progress */
+        virNodeSuspendUnlock();
+        return -1;
+    } else {
+        aboutToSuspend = true;
+    }
+
+    virNodeSuspendUnlock();
+
+    /* Check if the host supports the requested suspend target */
+    switch (target) {
+    case VIR_NODE_SUSPEND_TARGET_MEM:
+        if (hostPMFeatures & VIR_NODE_SUSPEND_TARGET_MEM) {
+            cmdString = strdup("pm-suspend");
+            if (cmdString == NULL) {
+                virReportOOMError();
+                goto cleanup;
+            }
+            break;
+        }
+        virNodeSuspendError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", _("Suspend-to-RAM"));
+        goto cleanup;
+
+    case VIR_NODE_SUSPEND_TARGET_DISK:
+        if (hostPMFeatures & VIR_NODE_SUSPEND_TARGET_DISK) {
+            cmdString = strdup("pm-hibernate");
+            if (cmdString == NULL) {
+                virReportOOMError();
+                goto cleanup;
+            }
+            break;
+        }
+        virNodeSuspendError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", _("Suspend-to-Disk"));
+        goto cleanup;
+
+    case VIR_NODE_SUSPEND_TARGET_HYBRID:
+        if (hostPMFeatures & VIR_NODE_SUSPEND_TARGET_HYBRID) {
+            cmdString = strdup("pm-suspend-hybrid");
+            if (cmdString == NULL) {
+                virReportOOMError();
+                goto cleanup;
+            }
+            break;
+        }
+        virNodeSuspendError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", _("Hybrid-Suspend"));
+        goto cleanup;
+
+    default:
+        virNodeSuspendError(VIR_ERR_INVALID_ARG, "%s", _("Invalid suspend target"));
+        goto cleanup;
+    }
+
+    /* Just set the RTC alarm. Don't suspend yet. */
+    if (virNodeSuspendSetNodeWakeup(duration) < 0)
+        goto cleanup;
+
+    if (virThreadCreate(&thread, false, virNodeSuspend, (void *)cmdString) < 0) {
+        virNodeSuspendError(VIR_ERR_INTERNAL_ERROR, "%s",
+                        _("Failed to create thread to suspend the host\n"));
+        goto cleanup;
+    }
+
+    return 0;
+
+cleanup:
+    VIR_FREE(cmdString);
+    return -1;
+}
+
diff --git a/src/util/virnodesuspend.h b/src/util/virnodesuspend.h
new file mode 100644
index 0000000..1432b5c
--- /dev/null
+++ b/src/util/virnodesuspend.h
@@ -0,0 +1,36 @@
+/*
+ * virnodesuspend.h: Support for suspending a node (host machine)
+ *
+ * Copyright (C) 2011 Srivatsa S. Bhat <srivatsa bhat linux vnet ibm com>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
+ *
+ */
+
+
+#ifndef __VIR_NODE_SUSPEND_H__
+# define __VIR_NODE_SUSPEND_H__
+
+#include "internal.h"
+
+int nodeSuspendForDuration(virConnectPtr conn,
+                           unsigned int target,
+                           unsigned long long duration,
+                           unsigned int flags);
+
+int virNodeSuspendInit(void);
+
+
+#endif /* __VIR_NODE_SUSPEND_H__ */
diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c
index beb2ba3..1837862 100644
--- a/src/xen/xen_driver.c
+++ b/src/xen/xen_driver.c
@@ -51,6 +51,7 @@
 #include "fdstream.h"
 #include "virfile.h"
 #include "command.h"
+#include "virnodesuspend.h"
 
 #define VIR_FROM_THIS VIR_FROM_XEN
 
@@ -2249,6 +2250,7 @@ static virDriver xenUnifiedDriver = {
     .domainEventRegisterAny = xenUnifiedDomainEventRegisterAny, /* 0.8.0 */
     .domainEventDeregisterAny = xenUnifiedDomainEventDeregisterAny, /* 0.8.0 */
     .domainOpenConsole = xenUnifiedDomainOpenConsole, /* 0.8.6 */
+    .nodeSuspendForDuration = nodeSuspendForDuration, /* 0.9.8 */
 };
 
 /**


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]