[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/14] Remove internal only virHostPMCapability enum



On Tue, Nov 29, 2011 at 09:13:57AM -0700, Eric Blake wrote:
> On 11/29/2011 08:44 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange redhat com>
> > 
> > The internal virHostPMCapability enum just duplicates the
> > public virNodeSuspendTarget enum, but with different names.
> > 
> > * src/util/util.c: Use VIR_NODE_SUSPEND_TARGET constants
> > * src/util/util.h: Remove virHostPMCapability enum
> > * src/conf/capabilities.c: Use VIR_NODE_SUSPEND_TARGET_LAST
> > ---
> >  src/conf/capabilities.c |    2 +-
> >  src/util/util.c         |   18 +++++++++---------
> >  src/util/util.h         |    8 --------
> >  3 files changed, 10 insertions(+), 18 deletions(-)
> > 
> 
> > +++ b/src/util/util.h
> > @@ -263,14 +263,6 @@ void virTypedParameterArrayClear(virTypedParameterPtr params, int nparams);
> >  
> >  /* Power Management Capabilities of the host system */
> >  
> > -enum virHostPMCapability {
> > -    VIR_HOST_PM_S3,              /* Suspend-to-RAM */
> > -    VIR_HOST_PM_S4,              /* Suspend-to-Disk */
> > -    VIR_HOST_PM_HYBRID_SUSPEND,  /* Hybrid-Suspend */
> > -
> > -    VIR_HOST_PM_LAST
> > -};
> > -
> >  VIR_ENUM_DECL(virHostPMCapability)
> 
> Also drop the VIR_ENUM_DECL(virHostPMCapability).
> 
> ACK to the intent, but this is incomplete.

See patch 4 :-)


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]