[libvirt] [PATCHv2 2/6] qemu: Plug memory leak onqemuProcessWaitForMonitor() error path

ajia at redhat.com ajia at redhat.com
Wed Nov 30 06:49:51 UTC 2011


From: Alex Jia <ajia at redhat.com>

Detected by Coverity. Leak introduced in commit 109efd7.

Signed-off-by: Alex Jia <ajia at redhat.com>
---
 src/qemu/qemu_process.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 2563f97..b05c280 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -1224,7 +1224,7 @@ qemuProcessWaitForMonitor(struct qemud_driver* driver,
 
         if (VIR_ALLOC_N(buf, buf_size) < 0) {
             virReportOOMError();
-            return -1;
+            goto closelog;
         }
 
         if (qemuProcessReadLogOutput(vm, logfd, buf, buf_size,
-- 
1.7.1




More information about the libvir-list mailing list