[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 07/14] Move suspend capabilities APIs out of util.h into virnodesuspend.c



On Tue, Nov 29, 2011 at 11:31:30PM +0530, Srivatsa S. Bhat wrote:
> On 11/29/2011 09:14 PM, Daniel P. Berrange wrote:
> 
> > From: "Daniel P. Berrange" <berrange redhat com>
> > 
> > +
> > +
> > +/**
> > + * virNodeSuspendSupportsTarget:
> > + * @target: The power management target to check whether it is supported
> > + *           by the host. Values could be:
> > + *           VIR_NODE_SUSPEND_TARGET_MEM
> > + *           VIR_NODE_SUSPEND_TARGET_DISK
> > + *           VIR_NODE_SUSPEND_TARGET_HYBRID
> > + * @supported: set to true if supported, false otherwise
> > + *
> > + * Run the script 'pm-is-supported' (from the pm-utils package)
> > + * to find out if @target is supported by the host.
> > + *
> > + * Returns 0 if the query was successful, -1 on failure.
> > + */
> > +int
> > +virNodeSuspendSupportsTarget(unsigned int target, bool *supported)
> > +{
> 
> 
> We can mark this function as static, since it is only ever called by
> virNodeSuspendGetTargetMask().


Yes, good point. Will make that change


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]